Added doc update how to start chaincode as a service, and how to set grpc parameters in the startup #423
Conversation
…grpc parameters in the startup Signed-off-by: Santosh Kumar <[email protected]>
Signed-off-by: Santosh Kumar <[email protected]>
Signed-off-by: Santosh Kumar <[email protected]>
Signed-off-by: Santosh Kumar <[email protected]>
Signed-off-by: Santosh Kumar <[email protected]>
Signed-off-by: Santosh Kumar <[email protected]>
There was a problem hiding this comment.
The documentation for chaincode-as-a-service all appears under the Usage sub-heading of the Chaincode Interface section of the document. For clarity, it might be better to have either:
- A specific section for chaincode-as-a-service; or
- A sub-heading for chaincode-as-a-service under both the Contract Interface and Chaincode Interface sections, with information relevant to those APIs.
The low-level chaincode interface was superseded by the higher-level contract interface with Fabric v1.4. We should be directing users to the contract interface. I don't mind having chaincode interface information here for completeness, but it should be secondary to the contract interface. I would be equally happy to remove the chaincode interface content.
Not an issue with the changes you've made, but I notice that there are errors in the example code. Really any code samples we include in the documentation should be correct. Alternatively we could reference known good sample code, either in this repository or in the fabric-samples respository. No need to tackle that in this PR though.
Signed-off-by: Santosh Kumar <[email protected]>
|
@bestbeforetoday Thank you for your inputs. I have made some changes as per your inputs. Please review it. Thank you! |
Signed-off-by: Santosh Kumar [email protected]
#419 Added doc update how to start chaincode as a service, and how to set grpc parameters in the startup